420 change github workflow to run test with feature flags #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-yap
force-pushed
the
420-change-github-workflow-to-run-tests-with-feature-flags
branch
from
53ce42c
to
7b0a48d
Compare
ebma
reviewed
Sep 11, 2024
b-yap
added a commit
that referenced
this pull request
Sep 12, 2024
b-yap
added a commit
that referenced
this pull request
Sep 12, 2024
b-yap
force-pushed
the
420-change-github-workflow-to-run-tests-with-feature-flags
branch
from
bfd9e9d
to
b5f3ef2
Compare
There was a problem hiding this comment.
Similar to @ebma's question, to me the intention of #420 is not entirely clear: is the task to 1) just filter out all test for --features runtime-benchmarks or is it to 2) make these tests work also for --features runtime-benchmarks.
The issue says:
This allows for changes that break benchmarks to pass the pipeline and therefore be merged into the main branch
This almost sounds to me like it means option 2.
b-yap
added a commit
that referenced
this pull request
Sep 19, 2024
b-yap
force-pushed
the
420-change-github-workflow-to-run-tests-with-feature-flags
branch
from
9ef613f
to
d295174
Compare
|
Let's wait for #485 to be merged before we merge this one to avoid conflicts with the workflow definitions. |
This reverts commit e03041e.
…fault weight" This reverts commit 79012a1.
``` error[E0046]: not all trait items implemented, missing: `try_successful_origin` --> /Users/b.carlayap/.cargo/git/checkouts/cumulus-59522f43471fa161/f603a61/parachains/runtimes/assets/common/src/foreign_creators.rs:28:1 | 28 | / impl< 29 | | IsForeign: ContainsPair<MultiLocation, MultiLocation>, 30 | | AccountOf: Convert<MultiLocation, AccountId>, 31 | | AccountId: Clone, ... | 36 | | RuntimeOrigin::PalletsOrigin: 37 | | From<XcmOrigin> + TryInto<XcmOrigin, Error = RuntimeOrigin::PalletsOrigin>, | |___________________________________________________________________________________^ missing `try_successful_origin` in implementation ``` just yet
…ob/30039330371#step:5:1949
…ime` move the benchmark to another workflow
update CI to 1 file only
b-yap
force-pushed
the
420-change-github-workflow-to-run-tests-with-feature-flags
branch
from
d295174
to
40f0e15
Compare
ebma
approved these changes
Oct 28, 2024
b-yap
deleted the
420-change-github-workflow-to-run-tests-with-feature-flags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #420
Add another step to run a test but with features
runtime-benchmarksandtry-runtime.This also removes
nightly