Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error management #223

Merged
merged 3 commits into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions ui-src/components/LibraryError.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import { Banner, Button, IconWarning32, Link } from '@create-figma-plugin/ui';

import { useFigmaContext } from '@ui/context';

import { Stack } from './Stack';

export const LibraryError = () => {
const { reload, cancel, error } = useFigmaContext();

if (!error) return null;

return (
<Stack space="small">
<Stack space="xsmall">
<Banner icon={<IconWarning32 />} variant="warning">
Oops! It looks like there was an <b>error generating the export file</b>.
</Banner>
<span>
Please open an issue in our{' '}
<Link
href="https://github.com/penpot/penpot-exporter-figma-plugin/issues"
target="_blank"
rel="noreferrer"
>
Github repository
</Link>
, and we&apos;ll be happy to assist you!
</span>
<Stack space="xsmall" direction="row">
<Button onClick={reload} fullWidth>
Reload
</Button>
<Button secondary onClick={cancel} fullWidth>
Cancel
</Button>
</Stack>
</Stack>
</Stack>
);
};
5 changes: 4 additions & 1 deletion ui-src/components/PenpotExporter.tsx
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
import { LoadingIndicator } from '@create-figma-plugin/ui';

import { LibraryError } from '@ui/components/LibraryError';
import { useFigmaContext } from '@ui/context';

import { ExportForm } from './ExportForm';
import { ExporterProgress } from './ExporterProgress';
import { PluginReload } from './PluginReload';

export const PenpotExporter = () => {
const { loading, needsReload, exporting } = useFigmaContext();
const { loading, needsReload, exporting, error } = useFigmaContext();

if (loading) return <LoadingIndicator />;

if (exporting) return <ExporterProgress />;

if (needsReload) return <PluginReload />;

if (error) return <LibraryError />;

return <ExportForm />;
};
8 changes: 7 additions & 1 deletion ui-src/context/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ type PluginMessage =
| ProgressStepMessage
| ProgressCurrentItemMessage
| ProgressTotalItemsMessage
| ProgressProcessedItemsMessage;
| ProgressProcessedItemsMessage
| ErrorMessage;

type PenpotDocumentMessage = {
type: 'PENPOT_DOCUMENT';
Expand Down Expand Up @@ -47,6 +48,11 @@ type ProgressProcessedItemsMessage = {
data: number;
};

type ErrorMessage = {
type: 'ERROR';
data: string;
};

export const sendMessage = (pluginMessage: PluginMessage) => {
window.dispatchEvent(
new MessageEvent<MessageData>('message', {
Expand Down
21 changes: 19 additions & 2 deletions ui-src/context/useFigma.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export type UseFigmaHook = {
needsReload: boolean;
loading: boolean;
exporting: boolean;
error: boolean;
step: Steps | undefined;
currentItem: string | undefined;
totalItems: number;
Expand Down Expand Up @@ -38,6 +39,7 @@ export const useFigma = (): UseFigmaHook => {
const [needsReload, setNeedsReload] = useState(false);
const [loading, setLoading] = useState(true);
const [exporting, setExporting] = useState(false);
const [error, setError] = useState(false);

const [step, setStep] = useState<Steps>();
const [currentItem, setCurrentItem] = useState<string | undefined>();
Expand All @@ -62,9 +64,16 @@ export const useFigma = (): UseFigmaHook => {
data: 'exporting'
});

const blob = await file.export();
const blob = await file.export().catch(error => {
sendMessage({
type: 'ERROR',
data: error.message
});
});

download(blob, `${pluginMessage.data.name}.zip`);
if (blob) {
download(blob, `${pluginMessage.data.name}.zip`);
}

setExporting(false);
setStep(undefined);
Expand Down Expand Up @@ -98,6 +107,12 @@ export const useFigma = (): UseFigmaHook => {
setProcessedItems(pluginMessage.data);
break;
}
case 'ERROR': {
setError(true);
setLoading(false);
setExporting(false);
break;
}
}
};

Expand All @@ -113,6 +128,7 @@ export const useFigma = (): UseFigmaHook => {

const reload = () => {
setLoading(true);
setError(false);
postMessage('reload');
};

Expand Down Expand Up @@ -143,6 +159,7 @@ export const useFigma = (): UseFigmaHook => {
needsReload,
loading,
exporting,
error,
step,
currentItem,
totalItems,
Expand Down
Loading