Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: use new penpot-frontend image based on nginx-unprivileged #8

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bameda
Copy link
Member

@bameda bameda commented Oct 10, 2024

No description provided.

@alverad-katsuro
Copy link

alverad-katsuro commented Oct 12, 2024

Hello, you open MR in penpot project with Dockerfile? I like try with this build

@bameda
Copy link
Member Author

bameda commented Oct 18, 2024

Hi @alverad-katsuro

I have applied all the changes you recommended (with some small “aesthetic changes”).

I just have a doubt with the value of targetPort in route.yml. The new images will use port 8080 instead of the http currently used (in frontend-service.yml we've changed targetPort from http to 8080).

Do we have to make this change in route.yml too?

@bameda bameda force-pushed the penpot-frontend-unprivileged-image branch from 67c1191 to 36ca179 Compare October 21, 2024 07:25
@alverad-katsuro
Copy link

Hello @bameda

I apologize for the delay, yes it is necessary to route, I saw that you uploaded the changes, I will test penpot-frontend-unprivileged-image this weekend and I will send you feedback

@bameda
Copy link
Member Author

bameda commented Oct 25, 2024

Thank you very much. There is no hurry because it will almost certainly not be released until 2.4. But your validation is highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants