-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locators): Locators have been replaced with more resilient ones to better handle layout changes. #107
Conversation
# Conflicts: # pages/profile-page.js
…' into refactor-locators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! I've put some comments. Two more suggestions:
-
I've read the commit messages and in this case it's better to have a single commit for the whole PR.
-
I've run the tests and some of them failed. Could you please check it?
Thanks!
Ran the tests, 7 failed because: 6 tests failed due to new accounts landing directly in the workspace instead of the dashboard (this changed today on PRE). |
This comment was marked as resolved.
This comment was marked as resolved.
Changes reviewed! Just one task and it's approved: a single commit for the whole PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Condition: you should have a single commit for the whole PR (because all commits are about the same thing)
Locators have been replaced with more resilient ones to better handle layout changes.
Updated screenshots according to the new locators
Modified tests according to the new locators
Added fixes to improve test stability
Updated the README as some information was outdated.