fix(linux): update outdated snapshots after release 2.4 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-herrero
force-pushed
the
dherrero/bugfix/linux-snapshots-2.4
branch
from
4462241 to
30be4d2
Compare
daniel-herrero
changed the title
tdelatorre
requested changes
Dec 13, 2024
There was a problem hiding this comment.
There are some changes in the snapshots of the view-mode test from dark mode to light mode (both Chrome and Firefox).
I checked the same snapshots on Win32 and all of them are in dark mode, so I think they are incorrect in light mode.
Sometimes after running the light mode tests, the test does not recover to dark mode and the snapshots are generated incorrectly.
It is recommended to review all the generated snapshots.
daniel-herrero
force-pushed
the
dherrero/bugfix/linux-snapshots-2.4
branch
from
30be4d2 to
d5fcae2
Compare
daniel-herrero
force-pushed
the
dherrero/bugfix/linux-snapshots-2.4
branch
from
d5fcae2 to
08206a0
Compare
|
All the light-dark-mode issues should be fixed by now. Well caught! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates snapshots for linux after the release 2.4, fixing mainly the new masks.