fix no_std incompatibility
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hashbrown` has the `HashMap` impl for the Rust standard library since 1.36, but the original crate has the `no_std` version
hex=0.4.3 was breaking the build, see: KokaKiwi/rust-hex#55 cargo-nono was reporting false positives on zeroize and num-bigint, so instead of using that in CI I'm instead building without the default `std` feature
redshiftzero
force-pushed
the
no-std-incompat
branch
from
fee902d
to
45a3754
Compare
redshiftzero
force-pushed
the
no-std-incompat
branch
from
45a3754
to
c88fb2c
Compare
redshiftzero
changed the title
no_std incompatibilityno_std incompatibility
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #58 I went to add
cargo-nonoto CI and discovered a number of places where there areno_stdincompatibilities, this PR aims to resolve thoseTowards penumbra-zone/penumbra#3512