API Cleanup and Completion #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
force-pushed
the
85-cleanup
branch
from
b809e9e
to
d9ce555
Compare
TalDerei
reviewed
Feb 7, 2024
src/fields/fp/u64/wrapper.rs
Outdated
| @@ -57,59 +57,51 @@ impl Fp { | |||
| bytes | |||
| } | |||
|
|
|||
| pub const fn from_montgomery_limbs(limbs: [u64; N]) -> Fp { | |||
| const fn from_montgomery_limbs_backend(limbs: [u64; N]) -> Fp { | |||
There was a problem hiding this comment.
duplicate with from_montgomery_limbs for u64
|
This looks pretty straightforward to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85