-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: pub visibility modifier #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from_montgomery_limbs and from_raw_bytes shouldn't be exposed. The former is impossible to use correctly unless you really know the constants and what's going on internally. The latter should be replaced with the _mod_order version that's already exposed.
I kept |
We absolutely do not want to allow doing that, instead, we should use the Fq::SENTINEL value |
We realized while modifying poseidon377 to work in embedded environments (ref: penumbra-zone/poseidon377#53) that we'll need |
closing in favor of #98 |
This is required, otherwise the monorepo will complain about some wrapper functions being private associated functions.