pindexer: implement symmetrization of charts #4941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now charts implement price information from both directions of a pair.
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
vacekj
reviewed
Nov 24, 2024
|
is this good to merge or does it require db changes? wondering if we could flush the pipeline and get it into the preview deployment |
Co-authored-by: Josef <[email protected]> Signed-off-by: Lúcás Meier <[email protected]>
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
|
This has no breaking change to the DB schema, it just changes the data inside of it, so I think we can deploy as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now charts implement price information from both directions of a pair.
This is needed for correct rendering on the dex explorer.
For testing, run a local copy of the dex explorer and notice that now both charts are better inverses of each other.
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: