build: support 'nix build' for cometbft archive #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing build.rs script assumes that go has been set up sufficiently, and calls out to it to build the static library for cometbft for linking against. That's rad, but naively calling out to `go build` from inside `nix build` fails, because the rust overlay doesn't know anything about golang, and forbids arbitrary network calls. Instead, we'll have to be explicit about preparing the `libcomebft.a` static lib as a discrete output, and consuming it as an input in the rust build. We can do so by opting in to using a prebuilt lib via env var in the `build.rs` script. This change improves the nix config, making it sufficiently defined to perform a `nix build` successfully. Careful attention was given to preserving the existing functionality so that `cargo build` will still do the right thing, as long as golang is available.
conorsch
force-pushed
the
nix-multi-stage
branch
from
dbde89b
to
7822463
Compare
conorsch
changed the title
cronokirby
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
build.rsscript assumes that go has been set up sufficiently, and calls out to it to build the static library for cometbft for linking against. That's rad, but naively calling out togo buildfrom insidenix buildfails, because the rust overlay doesn't know anything about golang, and forbids arbitrary network calls.Instead, we'll have to be explicit about preparing the
libcomebft.astatic lib as a discrete output, and consuming it as an input in the rust build. We can do so by opting in to using a prebuilt lib via env var in thebuild.rsscript.This change improves the nix config, making it sufficiently defined to perform a
nix buildsuccessfully. Careful attention was given to preserving the existing functionality so thatcargo buildwill still do the right thing, as long as golang is available.