Expose register method to manually subscribe new user #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nico2che
force-pushed
the
master
branch
4 times, most recently
from
1bfeb22 to
f478e9b
Compare
rwngallego
requested changes
Jan 29, 2022
There was a problem hiding this comment.
Hi @nico2che thanks a lot for your PR! The idea is great and thanks for the webpack exports changes. The only small change is the name of the isRegister export.
I will need to do some extra refactoring of the current SDK code after this merge in order to better support this new feature. Thanks a lot!
| start, | ||
| register, | ||
| unregister, | ||
| isRegister |
| @@ -112,8 +116,35 @@ const PerfectyPush = (() => { | |||
| await Registration.check(Storage.userId(), Storage.optedOut()) | |||
| } | |||
|
|
|||
| const register = async () => { | |||
| Options.askPermissionsDirectly = true | |||
There was a problem hiding this comment.
We should not alter user options but instead adjust the existing code to support explicit registrations called from JS. I will refactor the current code in Perfecty in order to support what you intend to do in a separate PR.
|
Please check the failing CI job, I've allowed it to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this plugin!
What do you think about this? I would like to design my own dialog so I exposed three methods:
PerfectyPush.register(): Promise<boolean>ask for permission, return promise fulfilled by user actionPerfectyPush.unregister(): Promise<boolean>PerfectyPush.isRegister(): booleancheck if this browser have permission and is registered