Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slim to 3.12.3 #333

Merged
merged 66 commits into from
Jan 17, 2022
Merged

Update Slim to 3.12.3 #333

merged 66 commits into from
Jan 17, 2022

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Sep 22, 2020

@glensc glensc self-assigned this Sep 22, 2020
@glensc
Copy link
Contributor Author

glensc commented Sep 22, 2020

Seems to me it's perhaps easier to start with a slim skeleton:

and transfer logic to new locations

@glensc
Copy link
Contributor Author

glensc commented Oct 9, 2020

slim/views have no v3 support:

PHP Fatal error:  Class 'Slim\View' not found in vendor/slim/views/Twig.php on line 45

@glensc glensc force-pushed the slim-upgrade branch 2 times, most recently from ab4066f to 7289a33 Compare October 14, 2020 12:25
@glensc glensc force-pushed the slim-upgrade branch 2 times, most recently from 1fb49c8 to ca57682 Compare October 30, 2020 14:49
@glensc
Copy link
Contributor Author

glensc commented Nov 2, 2020

@glensc glensc force-pushed the slim-upgrade branch 2 times, most recently from 52838c8 to 45f563f Compare December 21, 2020 09:40
@glensc
Copy link
Contributor Author

glensc commented Dec 21, 2020

@glensc glensc force-pushed the slim-upgrade branch 3 times, most recently from 3c43495 to f8f8361 Compare December 27, 2020 19:36
@glensc glensc force-pushed the slim-upgrade branch 2 times, most recently from 939f516 to 196b17b Compare January 21, 2021 20:22
@glensc
Copy link
Contributor Author

glensc commented Jan 21, 2021

The v2 code mocked POST data by overwriting $_POST:

This is very different in v3:

@glensc
Copy link
Contributor Author

glensc commented Jan 21, 2021

Flash messages have new package:

@glensc
Copy link
Contributor Author

glensc commented Jan 24, 2021

https://github.com/slimphp/Slim-Flash#using-with-twig-view

If you use Twig-View, then slim-twig-flash may be a useful integration package:

@glensc
Copy link
Contributor Author

glensc commented Feb 12, 2021

@glensc glensc reopened this Feb 12, 2021
@glensc glensc marked this pull request as ready for review January 16, 2022 22:51
@glensc glensc changed the title [0.19]: Update Slim to 3.12.3 [0.20]: Update Slim to 3.12.3 Jan 16, 2022
@glensc glensc changed the base branch from 0.19.x to 0.20.x January 17, 2022 16:56
@glensc glensc added this to the 0.20.0 milestone Jan 17, 2022
@glensc glensc merged commit e363c42 into 0.20.x Jan 17, 2022
@glensc glensc deleted the slim-upgrade branch January 17, 2022 16:57
@glensc glensc changed the title [0.20]: Update Slim to 3.12.3 Update Slim to 3.12.3 Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I update PHP to 7.4. Slim reports an error.
4 participants