fix(json): modify json.lua to support larger numbers #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one approach, there are many ways to handle. But given wasm64 and lua 5.3+ support 64 bit integers more precision should be given to raw numbers when encoding. Ref: permaweb/aos#384
dev-cli/container/src/json.lua
Outdated
| return string.format("%.0f", val) | ||
| else | ||
| -- Decimals: use the 'g' format to print floating point with precision, up to 14 significant digits | ||
| return string.format("%.14g", val) |
There was a problem hiding this comment.
I wonder if this should be .20g based on this comment. ao uses a compilation of Lua 5.3 which introduced the 64 bit integers.
There was a problem hiding this comment.
yep that would work. will make the change
There was a problem hiding this comment.
modified - 2c8aa83
Lua 5.3 supports 64 bit integers, which shouldn't need to be converted to strings. Floating point numbers will be rounded to 20 sig digits will be rounded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one approach, there are many ways to handle. But given wasm64 and lua 5.3+ support 64 bit integers more precision should be given to raw numbers when encoding.
Fixes #1054