Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add partial eval docs #403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

asafc
Copy link
Contributor

@asafc asafc commented Aug 13, 2024

No description provided.

@asafc asafc requested a review from omer9564 August 13, 2024 14:26
Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for permitio-docs ready!

Name Link
🔨 Latest commit 492ad3c
🔍 Latest deploy log https://app.netlify.com/sites/permitio-docs/deploys/66bb6cfa88c7930009fbb9c6
😎 Deploy Preview https://deploy-preview-403--permitio-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


* Partial evaluation currently is only supported for **RBAC** based policies. We are working to expand support to ReBAC and ABAC as well.
* You'd need to run at least version 0.6.0 of the PDP
* Currently only the python SDK support partial evaluation, starting at version 2.7.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this to the feature parity docs

* Currently only the python SDK support partial evaluation, starting at version 2.7.0.
* We currently only support translation of the compiled policies to SQLAlchemy ORM queries.
* More SDKs will be supported in the future as well as more ORMs.
* The source code for the data filtering library is here, we would love to accept community contributions to support more ORMs or direct SQL plugins.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to add the link to the "here"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I find the name resources potentially confusing with the existing filter_objects
  • the fact we have on the same page one example in Go and one in Python feels odd
  • This article is pretty long- I'd suggest moving it to a page of its own (linked from this page, or a shared parent of the current page - i.e. data filtering main page pointing to two pages of the two options )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants