Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more recent websockets version #72

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Conversation

Graeme22
Copy link
Contributor

Updates the websockets dependency to allow more recent versions. Previously was pinned to <11.

Fixes #71

@roekatz roekatz self-requested a review April 21, 2024 08:22
Copy link
Contributor

@roekatz roekatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Graeme22 !

@roekatz roekatz merged commit 3d6bc24 into permitio:master Apr 21, 2024
2 of 6 checks passed
@orweis
Copy link
Contributor

orweis commented Apr 21, 2024

@danielbass37 as per customary offer @Graeme22 some thank you swag :)

@Graeme22
Copy link
Contributor Author

No problem! Any chance we could get a fresh release sometime soon? This conflicts with another library I'm using!

@Graeme22
Copy link
Contributor Author

If you'd like, I can open a PR in the fastapi_websockets_rpc repo as well, seems like it has the same issues.

@orweis
Copy link
Contributor

orweis commented Apr 23, 2024

1- Yes.
2- please do 🙏

@Graeme22
Copy link
Contributor Author

Ok, opened one. Thanks for the quick responses!

@danielbass37
Copy link

Hey @Graeme22 ! Thank you so much for your contribution! Are you already in our Slack community, perchance?

@Graeme22
Copy link
Contributor Author

Negative

@danielbass37
Copy link

@Graeme22 Well, first of all, you are more than welcome to join: https://bit.ly/permit-slack
We'd also love to send some swag as a thanks form us for your contribution to the project! If your'e down for that, just DM me in the community once you join, and I can make sure we send something your way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for websockets>=11?
4 participants