Fix failing tests - broadcaster disconnection & multiprocess #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafc
approved these changes
Apr 24, 2024
roekatz
force-pushed
the
rk/fix-broadcaster-disconnection-test
branch
from
efe3bb9
to
86c5ff2
Compare
roekatz
force-pushed
the
rk/fix-broadcaster-disconnection-test
branch
from
8f203b9
to
00ebbb7
Compare
roekatz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condition in broadcaster disconnection test by closing Websocket connection after disconnection.
Fix multiprocess test by switching from
asyncio.get_event_loop().run_until_completetoasyncio.run(which is higher level, more stable and recommended to use)