@gemanor do we have to add unit test for the login component? As we are modifying the component itself in #13 and i see that the tests are included for them

@quest-bot loot #12

Quest PR submitted!

@Abiji-2020, you are attempting to solve the issue and loot this Quest. Will you be successful?

Questions? Check out the docs.

@Abiji-2020, yes, I would wait for #37 and then merge from main to ensure we have 90% coverage.
I'll let you know when mergin it.

@Abiji-2020, yes, I would wait for #37 and then merge from main to ensure we have 90% coverage. I'll let you know when mergin it.

oh okayy,

@gemanor any updates on #37

No, we still waiting for Jay to submit the CR changes

@gemanor do we need tests for the hooks??

All the components have their individual unit tests, and also the complete flow test by combining it, the major reduce in coverage is due to hooks and

• https://github.com/permitio/permit-cli/blob/main/source/components/EnvSelectionWizard.tsx
• https://github.com/permitio/permit-cli/blob/main/source/components/WorkspaceSelector.tsx

even though they are commented they are included in the coverage

You can remove these files @Abiji-2020

And to your question, yes, hooks has critical logic in it. All the hooks that being used, should have tests

coverage increased to 90%

@gemanor

@gemanor could you take a look at this?

Hey @Abiji-2020, the tests have not been passed on my local machine. Can you check that?

This is the result:

stderr | tests/logout.test.tsx > Logout > should render the logout component and call process.exit
Mocked process.exit(0)

 ✓ tests/SelectProject.test.tsx (4)
 ✓ tests/hooks/useAuthApi.test.tsx (4)
 ✓ tests/PDPCheck.test.tsx (4)
 ✓ tests/lib/auth.test.ts (9)
 ✓ tests/EnvCopy.test.tsx (3) 425ms
 ✓ tests/EnvMember.test.tsx (2) 331ms
 ✓ tests/EnvSelect.test.tsx (7) 533ms
 ✓ tests/LoginFlow.test.tsx (5)
 ✓ tests/OPAPolicy.test.tsx (2)
 ✓ tests/PDPCheck.test.tsx (4)
 ✓ tests/PDPRun.test.tsx (1)
 ✓ tests/SelectEnvironment.test.tsx (4)
 ✓ tests/SelectOrganisation.test.tsx (5) 337ms
 ✓ tests/SelectProject.test.tsx (4)
 ❯ tests/apiKey.test.tsx (4)
   ❯ ApiKey (4)
     ✓ Should save the key
     ✓ Should validate the key
     × Should read the key
     ✓ Invalid Key
 ✓ tests/cli.test.tsx (1)
 ✓ tests/github.test.tsx (16) 3995ms
 ✓ tests/index.test.tsx (1)
 ✓ tests/login.test.tsx (1)
 ✓ tests/logout.test.tsx (1)
 ✓ tests/components/AuthProvider.test.tsx (5)
 ✓ tests/components/EnvironmentSelection.test.tsx (1)
 ✓ tests/components/PDPCommand.test.tsx (2)
 ✓ tests/hooks/useApiKeyAPI.test.tsx (6) 323ms
 ✓ tests/hooks/useAuthApi.test.tsx (4)
 ✓ tests/hooks/useEnvironmentApi.test.tsx (5)
 ✓ tests/hooks/useMemberAPI.test.tsx (2)
 ✓ tests/hooks/useOrganizationAPI.test.tsx (4)
 ✓ tests/hooks/useProjectAPI.test.tsx (2)
 ✓ tests/lib/api.test.ts (1)
 ✓ tests/lib/auth.test.ts (9)
 ✓ tests/lib/gitops_utils.test.ts (7)
 ✓ tests/utils/attributes.test.ts (12)

Hey @Abiji-2020, the tests have not been passed on my local machine. Can you check that?

This is the result:

stderr | tests/logout.test.tsx > Logout > should render the logout component and call process.exit
Mocked process.exit(0)

 ✓ tests/SelectProject.test.tsx (4)
 ✓ tests/hooks/useAuthApi.test.tsx (4)
 ✓ tests/PDPCheck.test.tsx (4)
 ✓ tests/lib/auth.test.ts (9)
 ✓ tests/EnvCopy.test.tsx (3) 425ms
 ✓ tests/EnvMember.test.tsx (2) 331ms
 ✓ tests/EnvSelect.test.tsx (7) 533ms
 ✓ tests/LoginFlow.test.tsx (5)
 ✓ tests/OPAPolicy.test.tsx (2)
 ✓ tests/PDPCheck.test.tsx (4)
 ✓ tests/PDPRun.test.tsx (1)
 ✓ tests/SelectEnvironment.test.tsx (4)
 ✓ tests/SelectOrganisation.test.tsx (5) 337ms
 ✓ tests/SelectProject.test.tsx (4)
 ❯ tests/apiKey.test.tsx (4)
   ❯ ApiKey (4)
     ✓ Should save the key
     ✓ Should validate the key
     × Should read the key
     ✓ Invalid Key
 ✓ tests/cli.test.tsx (1)
 ✓ tests/github.test.tsx (16) 3995ms
 ✓ tests/index.test.tsx (1)
 ✓ tests/login.test.tsx (1)
 ✓ tests/logout.test.tsx (1)
 ✓ tests/components/AuthProvider.test.tsx (5)
 ✓ tests/components/EnvironmentSelection.test.tsx (1)
 ✓ tests/components/PDPCommand.test.tsx (2)
 ✓ tests/hooks/useApiKeyAPI.test.tsx (6) 323ms
 ✓ tests/hooks/useAuthApi.test.tsx (4)
 ✓ tests/hooks/useEnvironmentApi.test.tsx (5)
 ✓ tests/hooks/useMemberAPI.test.tsx (2)
 ✓ tests/hooks/useOrganizationAPI.test.tsx (4)
 ✓ tests/hooks/useProjectAPI.test.tsx (2)
 ✓ tests/lib/api.test.ts (1)
 ✓ tests/lib/auth.test.ts (9)
 ✓ tests/lib/gitops_utils.test.ts (7)
 ✓ tests/utils/attributes.test.ts (12)

I guess you have not stored any key in the keychain so it is missing let me check and update that

@Abiji-2020, I extend the delay and now it passed locally, but not in the CI
Can you please check what happen in the CI and fix it?

@gemanor the library we use for copying the ssh keys cannot run in the normal actions so for that to run properly I have created a PR #44

Can we mock it instead? Having CI private versions could lead to security vulnerabilities and it's anti-pattern

I have gone through it but it is a problem with the package clipboardy which we are using for copying there is also another solution that sindresorhus/clipboardy#63 (comment)

It seems like it worked, but we still have problem with the keytar itself. Any idea?

we can install the libsecret-1.so.0 package in the ci? or else we need to mock keytar in all of them

What could be the implication of installing it in the CI?

I added it on main, so you can revert the ci changes you made..

All of them are working on the windows machine so let me check them and update them if any errors.

Okay, now it all failed. I think it is better to mock the keytar functions too..

I reverted the CI files, I think installing the lib-secret will just create more troubles. It's okay to mock the keytar IMO

@Abiji-2020 please let me know when you have a version with keytar functions mocked, and I'll re-run the CI tests

@Abiji-2020 please let me know when you have a version with keytar functions mocked, and I'll re-run the CI tests

ok @gemanor will update

@Abiji-2020, this is a good progress, seems like we are mostly good with it

yes 3 more test files should be modified .

@gemanor updated and fixed CI

🧚 @Abiji-2020 congratulations for completing Quest #12

💰 A reward of $250 has been credited to you.

To claim your $250 reward follow the instructions here.

Questions? Check out the docs.