Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MoveFromMouth Actions #80

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Added MoveFromMouth Actions #80

merged 4 commits into from
Sep 19, 2023

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented Aug 30, 2023

Describe this pull request. Link to relevant GitHub issues, if any.

This web app change corresponds to ada_feeding #56. Specifically, it adds two more states to the web app, for when it is moving above the plate from the mouth, and for when it is moving to the resting position from the mouth. It modifies the buttons after transfer to go to those states.

Explain how this pull request was tested, including but not limited to the below checkmarks.

  1. Launch the dummy nodes for robot motion and the web app.
    • Run the web app, trying a variety of buttons to transition between states. Verify that everything works as expected.
    • Click the button after transfer to move the robot above the plate. Verify that it calls MoveFromMouthToAbovePlate
    • Click the button after transfer to move the robot to the resting position. Verify that it calls MoveFromMouthToRestingPosition.
  2. Launch MoveIt, the actual robot motion nodes, etc. on the real robot.
    • Run the web app, trying a variety of buttons to transition between states. Verify that everything works as expected.
    • Click the button after transfer to move the robot above the plate. Verify that it calls MoveFromMouthToAbovePlate
    • Click the button after transfer to move the robot to the resting position. Verify that it calls MoveFromMouthToRestingPosition.

Before creating a pull request

  • Format React code with npm run format
  • Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

feedingwebapp/src/Pages/Home/Home.jsx Show resolved Hide resolved
feedingwebapp/src/Pages/Home/Home.jsx Show resolved Hide resolved
@amalnanavati amalnanavati merged commit 5c83b69 into main Sep 19, 2023
4 checks passed
@amalnanavati amalnanavati deleted the amaln/move_from_mouth branch September 19, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants