Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cert-notice readme #2504

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

WithHolm
Copy link
Contributor

PR Summary

Fix #2438

Updated so that there is a notice at top of readme and a list futher down of all certificate issuers, and thumbprint going back to 3.0.3

after installing all available versions from ps module store i ran the following command to list all the different module certificates

 get-module pester -ListAvailable|%{$sign = Get-AuthenticodeSignature -FilePath $_.Path;[pscustomobject]@{version=$_.version;issuer=$sign.SignerCertificate.Issuer;thumbprint=$sign.SignerCertificate.Thumbprint;subject=$sign.SignerCertificate.Subject}}|ft -a

after that i just manually found the different certificate thumbprint and figured out the certificate for the different certificate ranges.

I noted that 3.4.0 had a different certificate subject due to it being released as a w10 module, but this might be wrong.
3.0.3 -> 4.4.2 did not have any certificate (except for 3.4.0 )

PR Checklist

  • [x ] PR has meaningful title
  • [ x] Summary describes changes
  • [ x] PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • [ x] Tests are added/update (if required)
  • [ x] Documentation is updated/added (if required)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@nohwnd nohwnd merged commit b81b7cb into pester:main Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificate warning when upgrading to 5.6.0-beta1
3 participants