-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Giscus comments system #267
Draft
fflaten
wants to merge
5
commits into
pester:main
Choose a base branch
from
fflaten:giscus
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
56a963c
Add Giscus to docs-pages
fflaten 38a2d61
Adjust indent size for js-files
fflaten 3101144
Update README with upgrade warning about swizzle
fflaten 2f490a7
Update DocItem/Layout swizzle for Docusaurus v3
fflaten 2f9465f
Use CSS for margin
fflaten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"origins": [ | ||
"https://pester.dev", | ||
"https://pester-docs.netlify.app" | ||
], | ||
"originsRegex": [ | ||
"https://deploy-preview-[0-9]+--pester-docs.netlify.app", | ||
"http://localhost:[0-9]+" | ||
], | ||
"defaultCommentOrder": "oldest" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
import Head from '@docusaurus/Head'; | ||
import { useLocation } from '@docusaurus/router'; | ||
import { useColorMode } from '@docusaurus/theme-common'; | ||
import useBaseUrl from '@docusaurus/useBaseUrl'; | ||
import useDocusaurusContext from '@docusaurus/useDocusaurusContext'; | ||
import Giscus from "@giscus/react"; | ||
import React from 'react'; | ||
import styles from './styles.module.css'; | ||
|
||
/** | ||
* Adds a meta-tag to ensure new dicussion always add the canonical link in the initial post. | ||
* Avoids any localhost etc. if first reaction/post was made from a preview build | ||
* | ||
* See https://github.com/giscus/giscus/blob/main/ADVANCED-USAGE.md#giscusbacklink | ||
*/ | ||
export function GiscusHead() { | ||
const { | ||
siteConfig: { url: siteUrl }, | ||
} = useDocusaurusContext(); | ||
const { pathname } = useLocation(); | ||
const canonicalUrl = siteUrl + useBaseUrl(pathname); | ||
|
||
return ( | ||
<Head> | ||
<meta name="giscus:backlink" content={canonicalUrl} /> | ||
</Head> | ||
) | ||
} | ||
|
||
export function GiscusComponent() { | ||
const { colorMode } = useColorMode(); | ||
|
||
return ( | ||
<section className={styles.commentsSection}> | ||
<Giscus | ||
repo="fflaten/docs" | ||
repoId="MDEwOlJlcG9zaXRvcnkzMDY2ODYxNTc" | ||
category="Comments" | ||
categoryId="DIC_kwDOEkeozc4CWO6M" | ||
mapping="pathname" | ||
strict="1" | ||
reactionsEnabled="1" | ||
emitMetadata="0" | ||
inputPosition="top" | ||
theme={colorMode} | ||
lang="en" | ||
loading="lazy" | ||
crossorigin="anonymous" | ||
async | ||
/> | ||
</section> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.commentsSection { | ||
margin-top: 2rem; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
/** | ||
* Unsafe swizzle = might break in future minor upgrades. | ||
* Run "yarn swizzle @docusaurus/theme-classic DocItem/Layout --eject --danger" and compare the diff. | ||
* | ||
* Our customizations are marked with comments below | ||
*/ | ||
|
||
import React from 'react'; | ||
import clsx from 'clsx'; | ||
import { useWindowSize } from '@docusaurus/theme-common'; | ||
import { useDoc } from '@docusaurus/theme-common/internal'; | ||
import DocItemPaginator from '@theme/DocItem/Paginator'; | ||
import DocVersionBanner from '@theme/DocVersionBanner'; | ||
import DocVersionBadge from '@theme/DocVersionBadge'; | ||
import DocItemFooter from '@theme/DocItem/Footer'; | ||
import DocItemTOCMobile from '@theme/DocItem/TOC/Mobile'; | ||
import DocItemTOCDesktop from '@theme/DocItem/TOC/Desktop'; | ||
import DocItemContent from '@theme/DocItem/Content'; | ||
import DocBreadcrumbs from '@theme/DocBreadcrumbs'; | ||
import Unlisted from '@theme/Unlisted'; | ||
import styles from './styles.module.css'; | ||
/* Customization start */ | ||
import { GiscusHead, GiscusComponent } from '../../../components/Giscus/Giscus'; | ||
/* Customization end */ | ||
|
||
/** | ||
* Decide if the toc should be rendered, on mobile or desktop viewports | ||
*/ | ||
function useDocTOC() { | ||
const { frontMatter, toc } = useDoc(); | ||
const windowSize = useWindowSize(); | ||
const hidden = frontMatter.hide_table_of_contents; | ||
const canRender = !hidden && toc.length > 0; | ||
const mobile = canRender ? <DocItemTOCMobile /> : undefined; | ||
const desktop = | ||
canRender && (windowSize === 'desktop' || windowSize === 'ssr') ? ( | ||
<DocItemTOCDesktop /> | ||
) : undefined; | ||
return { | ||
hidden, | ||
mobile, | ||
desktop, | ||
}; | ||
} | ||
export default function DocItemLayout({ children }) { | ||
const docTOC = useDocTOC(); | ||
const { | ||
metadata: { unlisted }, | ||
} = useDoc(); | ||
return ( | ||
<div className="row"> | ||
<div className={clsx('col', !docTOC.hidden && styles.docItemCol)}> | ||
{unlisted && <Unlisted />} | ||
<DocVersionBanner /> | ||
<div className={styles.docItemContainer}> | ||
<article> | ||
<DocBreadcrumbs /> | ||
<DocVersionBadge /> | ||
{docTOC.mobile} | ||
<DocItemContent>{children}</DocItemContent> | ||
<DocItemFooter /> | ||
</article> | ||
<DocItemPaginator /> | ||
</div> | ||
{/* Customization start */} | ||
<GiscusHead /> | ||
<GiscusComponent /> | ||
{/* Customization end */} | ||
</div> | ||
{docTOC.desktop && <div className="col col--3">{docTOC.desktop}</div>} | ||
</div> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
.docItemContainer header + *, | ||
.docItemContainer article > *:first-child { | ||
margin-top: 0; | ||
} | ||
|
||
@media (min-width: 997px) { | ||
.docItemCol { | ||
max-width: 75% !important; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always add version here? Maybe possible to get current page version dynamically through
useDocusaurusContext()
to avoid hardcoding replace /docs/ with /docs/v5 for stable like we do in_redirects
?