Disable bounds check in critical character parsers.

petitparser · Jan 4, 2025 · eeef1ec · eeef1ec
1 parent 1a625cb
commit eeef1ec
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 0 deletions.
diff --git a/lib/src/parser/character/predicates/lookup.dart b/lib/src/parser/character/predicates/lookup.dart
@@ -32,6 +32,8 @@ class LookupCharPredicate extends CharacterPredicate {
 
   @inlineJs
   @inlineVm
+  @noBoundsChecksVm
+  @noBoundsChecksJs
   bool _testBit(int value) =>
       (bits[value >> _shift] & _mask[value & _offset]) != 0;
 

diff --git a/lib/src/parser/character/predicates/ranges.dart b/lib/src/parser/character/predicates/ranges.dart
@@ -2,6 +2,7 @@ import 'dart:typed_data';
 
 import 'package:collection/collection.dart' show ListEquality;
 
+import '../../../shared/annotations.dart';
 import '../predicate.dart';
 import 'range.dart';
 
@@ -21,6 +22,8 @@ class RangesCharPredicate extends CharacterPredicate {
   final Uint32List ranges;
 
   @override
+  @noBoundsChecksVm
+  @noBoundsChecksJs
   bool test(int value) {
     var min = 0;
     var max = ranges.length - 2;

diff --git a/lib/src/parser/predicate/single_character.dart b/lib/src/parser/predicate/single_character.dart
@@ -2,6 +2,7 @@ import 'package:meta/meta.dart';
 
 import '../../core/context.dart';
 import '../../core/result.dart';
+import '../../shared/annotations.dart';
 import '../character/predicate.dart';
 import '../character/predicates/constant.dart';
 import 'character.dart';
@@ -27,6 +28,8 @@ class SingleCharacterParser extends CharacterParser {
       : super.internal();
 
   @override
+  @noBoundsChecksVm
+  @noBoundsChecksJs
   Result<String> parseOn(Context context) {
     final buffer = context.buffer;
     final position = context.position;
@@ -37,6 +40,8 @@ class SingleCharacterParser extends CharacterParser {
   }
 
   @override
+  @noBoundsChecksVm
+  @noBoundsChecksJs
   int fastParseOn(String buffer, int position) =>
       position < buffer.length && predicate.test(buffer.codeUnitAt(position))
           ? position + 1
@@ -55,6 +60,8 @@ class AnySingleCharacterParser extends SingleCharacterParser {
         super.internal();
 
   @override
+  @noBoundsChecksVm
+  @noBoundsChecksJs
   Result<String> parseOn(Context context) {
     final buffer = context.buffer;
     final position = context.position;
@@ -64,6 +71,8 @@ class AnySingleCharacterParser extends SingleCharacterParser {
   }
 
   @override
+  @noBoundsChecksVm
+  @noBoundsChecksJs
   int fastParseOn(String buffer, int position) =>
       position < buffer.length ? position + 1 : -1;
 }
diff --git a/lib/src/parser/predicate/unicode_character.dart b/lib/src/parser/predicate/unicode_character.dart
@@ -29,6 +29,8 @@ class UnicodeCharacterParser extends CharacterParser {
       : super.internal();
 
   @override
+  @noBoundsChecksVm
+  @noBoundsChecksJs
   Result<String> parseOn(Context context) {
     final buffer = context.buffer;
     final position = context.position;
@@ -51,6 +53,8 @@ class UnicodeCharacterParser extends CharacterParser {
   }
 
   @override
+  @noBoundsChecksVm
+  @noBoundsChecksJs
   int fastParseOn(String buffer, int position) {
     if (position < buffer.length) {
       var codeUnit = buffer.codeUnitAt(position++);
@@ -81,6 +85,8 @@ class AnyUnicodeCharacterParser extends UnicodeCharacterParser {
         super.internal();
 
   @override
+  @noBoundsChecksVm
+  @noBoundsChecksJs
   Result<String> parseOn(Context context) {
     final buffer = context.buffer;
     final position = context.position;
@@ -98,6 +104,8 @@ class AnyUnicodeCharacterParser extends UnicodeCharacterParser {
   }
 
   @override
+  @noBoundsChecksVm
+  @noBoundsChecksJs
   int fastParseOn(String buffer, int position) {
     if (position < buffer.length) {
       if (_isLeadSurrogate(buffer.codeUnitAt(position++)) &&

diff --git a/lib/src/shared/annotations.dart b/lib/src/shared/annotations.dart
@@ -1,2 +1,5 @@
 const inlineVm = pragma('vm:prefer-inline');
 const inlineJs = pragma('dart2js:tryInline');
+
+const noBoundsChecksVm = pragma('vm:unsafe:no-bounds-checks');
+const noBoundsChecksJs = pragma('dart2js:index-bounds:trust');