-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloned subdirectory fails #22
Comments
Those are likely directories. Does the game work if you run it as normal from the commandline or if you manually create a .love file? |
Yeah they are folders with bunch of lua files inside. It works normally though when I run it with
. Note that i have other subdirectories in the modules folder as well that makelove is not complaining about. |
Upon further inspection it seems that if the directory has subdirectories, that directory is not included but the subdirectories are. example:
this will zip into:
|
Same issue here, my git submodule directories get broken (they're just left out entirely). Is there any workaround? Honestly I don't know how makelove can tell the difference, they're just normal directories. [Edit:] OK, found the problem (roughly) and the workaround. With the default config, makelove tries to be smart and only include files that git is tracking, but that part breaks with submodules.
love_files = [
"+./*", # Include all files.
"-*/.*", # Exclude all files & folders anywhere starting with '.'
"-./makelove*" # Make sure to exclude your build folder!
] |
Fix pfirsich#22: Cloned subdirectory fails ls-tree doesn't support --recurse-submodules, but --ls-files does. So provide it as an option.
Fix pfirsich#22: Cloned subdirectory fails ls-tree doesn't support --recurse-submodules, but --ls-files does. So provide it as an option.
i get errors like:
theyre originally cloned git repos. Ive tried removing the
.git
dir in each but it still gives the same errorThe text was updated successfully, but these errors were encountered: