Provide ::git-ls-files:: to resolve git submodules #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pfirsich#22: Cloned subdirectory fails ls-tree doesn't support --recurse-submodules, but --ls-files does. So provide it as an option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #22: Cloned subdirectory fails
ls-tree doesn't support --recurse-submodules, but --ls-files does. So
provide it as an option.
This is a draft because I'm not sure how it handles symlinks. Also, I think before merging this pr, there should be tests for handling different cases. I don't understand why ls-tree is used instead of ls-files except maybe because it wasn't clear how to get only filenames (
--abbrev=0was definitely unobvious).