-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always redirect STDOUT to logfile #19
Open
amalek215
wants to merge
10
commits into
pgaudit:integration
Choose a base branch
from
amalek215:redirect_stdout
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwsteele
requested changes
May 11, 2021
When testing on the CentOS8 Stream OS and trying to run the pgaudit_analyze binary as a daemon over an SSH connection, the entire SSH connection would hang and never return. After a lot of investigation, we were able to determine that this was happening when using openssh 8.0p1-9.el8 and also 8.0p1-8.el8. However, when you downgrade openssh to 8.0p1-7.el8, launching the daemon works as it has in the past. After digging through the openssh commits we found this: On May 2, 2021, CentOS 8 Stream packagers introduced a change to its openssh libraries, which you can see here: https://git.centos.org/rpms/openssh/c/1c3003998fcc4d40fe9e4544bca70dbc03324e65?branch=c8s After a lot more digging and testing, the issue was related to the fact that STDERR was never closed so in the newer openssh versions it would not release the connection and would hang. After this change we are able to run the pgaudit_analyze daemon over an SSH connection like before.
# Conflicts: # bin/pgaudit_analyze
dwsteele
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this paused waiting from a response from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run as a systemd process without the --daemon flag the
print
statements that implicitly use STDOUT do not make it into the logfile