Commits on Sep 29, 2024

1. Make handling of 'root_path' in dispatcher middleware adhere to ASGI … …

   …spec
   
   Before this change, the dispatcher middleware didn't do anything with
   'root_path'. It did, however, modify 'path'.
   
   The problem with this behavior, is that the child ASGI app has no way to
   determine what its prefix it. And if it can't determine its prefix, it
   doesn't know how to construct URLs.
   
   The ASGI spec isn't super clear on the expected behavior. However, some
   resources to review are:
   
   * https://asgi.readthedocs.io/en/latest/specs/www.html#wsgi-compatibility
   * encode/starlette#2400
   * django/asgiref#229
   
   Based on the above, I believe that the correct behavior is that
   "root_path" should be updated by the dispatcher middleware but that
   "path" should not be modified.
   
   In addition to the above change, I also updated the tests. And I also
   added a new test case where the dispatcher middleware is nested inside
   of itself.

   

   DaGenix committed Sep 29, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for fe0dbd6
   • Browse repository at this point

   Copy the full SHA

   fe0dbd6 View commit details

   Browse the repository at this point in the history