Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpine: add support for PostgreSQL 17 #61

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Conversation

komainu8
Copy link
Member

@komainu8 komainu8 commented Oct 4, 2024

No description provided.

@komainu8 komainu8 marked this pull request as draft October 4, 2024 06:39
@komainu8 komainu8 force-pushed the add-support-for-postgresql-17 branch from c3c384d to 5d5b310 Compare October 4, 2024 09:34
@abetomo abetomo force-pushed the add-support-for-postgresql-17 branch from 89ecdb6 to 1595d2c Compare October 7, 2024 08:25
if ! docker manifest inspect ${tag} > /dev/null; then
platforms="linux/amd64"
need_load=yes
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

リポジトリにイメージがないときはローカルのイメージで動くようにしてみましたがどうだろうか。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動いていそう。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ、常にローカルのやつを使うようにできる?
常にビルドしたやつでテストしたい。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushしないときはローカルのイメージでテストするようにしました。
platformsがlinux/amd64,linux/arm64だとローカルにloadするときにエラーになるので、linux/amd64のみにしています。

ERROR: docker exporter does not currently support exporting manifest lists

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

うっす。
alpine-17-slimは別PRでやる?ここでやる?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

別でやります!

.github/workflows/build.yml Outdated Show resolved Hide resolved
@abetomo abetomo marked this pull request as ready for review October 7, 2024 23:46
@kou kou merged commit 82aa407 into main Oct 7, 2024
16 of 32 checks passed
@kou kou deleted the add-support-for-postgresql-17 branch October 7, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants