Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend refactor #188

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Frontend refactor #188

wants to merge 11 commits into from

Conversation

rtemelkovski
Copy link
Collaborator

No description provided.

@rtemelkovski rtemelkovski marked this pull request as ready for review April 1, 2019 01:34
@rtemelkovski rtemelkovski requested a review from teovoinea April 1, 2019 01:34
@teovoinea
Copy link
Collaborator

It looks like we don't use boxLayout in this component. We can delete that one and rename this to boxLayout

mobilityai/frontend/mobilityai_react/App/Screens/Achievements.js

Line 82 in f800f8c

<View style={styles.boxLayout2}>

@teovoinea
Copy link
Collaborator

An error component as described in #122 for when http requests fail would be nice too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teovoinea teovoinea teovoinea requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtemelkovski @teovoinea