Fix: Analysis Text Output Preview #1560
Merged
+4
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file size using document.getElementId due to changes with react useeffect. Updated to set a state variable instead
joshsadam
reviewed
Dec 17, 2024
| @@ -108,7 +105,7 @@ export default function AnalysisTextPreview({ output }) { | |||
| </TextOutputWrapper> | |||
| <div> | |||
| <Space direction={"horizontal"}> | |||
| <span id={`${output.filename}-preview-status`}></span> | |||
| <span id={`${output.filename}-preview-status`}>{fileSizePreview}</span> | |||
There was a problem hiding this comment.
praise: This is a great way to handle it, not really sure why it wasn't set up like this to begin with.
joshsadam
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.
This PR fixes a bug with analysis text preview not being able to set the loaded file size using
document.getElementIddue to changes with react useeffect hook in react 18. Updated to set a state variable instead and that is used by the UI to display the loaded file size.Before fix:
After fix:
Related issue
Link to the GitHub issue this pull request addresses using the
#issuenumformat. If it completes an issue, useFixes #issuenumto automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted:
* [ ] CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.* [ ] Tests added (or description of how to test) for any new features.* [ ] User documentation updated for UI or technical changes.