Fix default behavior of literalEqual: #17467
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not share literals by default. Instead, do it if users explicitly request so in their implementation of literalEqual: Add tests
guillep
force-pushed
the
fix-compiler-literals
branch
from
03e2f7e
to
d88b166
Compare
|
Strange that we get this test broken MacOSX64.PharoDocComment.Tests.CommentTestCase.nil (from PharoDocComment-Tests) |
|
Looks like the doc comments integration with the CI is very bad at giving feedback :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not share literals by default.
Instead, do it if users explicitly request so in their implementation of literalEqual:
Add tests
Fixes #17264
=> the reason is that reflectivity pushes AST nodes to the literal frame, and literal nodes are consireded equal if they have the same contents (regarless of their position in the tree). Thus, two similar nodes in different part of the trees were considered equals and shared, avoiding reflectivity to call the right method on the right node.