-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer to phpcs.xml file if present. #312
base: master
Are you sure you want to change the base?
Conversation
jhedstrom
commented
Jan 5, 2017
- Fixes Defer to phpcs.xml/phpcs.xml.dist when present #311
This probably needs some tests. Also, it may require changes to
|
603bed5
to
bf1c0e4
Compare
Need to add 2 warnings here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra warning-handling requirement noted by @jhedstrom in comment.
bf1c0e4
to
78bb3b8
Compare
@grayside I've added the first warning, but cannot remember how the second warning actually differs. |
Hmm, this still needs a bit of work I think. The standard in the phpcs file isn't actually being used as the code in |