Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate isNodeType, nodeType #76

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nschloe
Copy link

@nschloe nschloe commented Feb 15, 2022

Not only did those classes not follow naming conventions (is_node_type, node_type), but they're also easily replacable by standard functions. Explicit is better than implicit, as the Zen of Python says, so here's a PR that deprecates the methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant