fix: Pass enable_runner_workflow_job_labels variable to submodule #4195
Conversation
Yethal
changed the title
|
@Yethal just wondering, already had time to work on this PR and get it in ready for review state? |
|
@npalm Honestly I don't even remember what was left to do here |
|
What problem are you trying to fix. I think the parameter is used only by the webhook module. Ci is failing as well. |
|
It doesn't work in multi-runner submodule without this change |
Please can you have a look on the CI, the change is ginving errors on the mult-runner examples |
|
@Yethal kind reminder the CI is broken as result of the PR. Would be great if you can have a look. In the mean time I move the PR in draft status. Please mark ready to review when you ar ready. |
| scale_down_schedule_expression = each.value.runner_config.scale_down_schedule_expression | ||
| minimum_running_time_in_minutes = each.value.runner_config.minimum_running_time_in_minutes | ||
| runner_boot_time_in_minutes = each.value.runner_config.runner_boot_time_in_minutes | ||
| runner_labels = sort(distinct(concat(["self-hosted", each.value.runner_config.runner_os, each.value.runner_config.runner_architecture], each.value.runner_config.runner_extra_labels))) |
There was a problem hiding this comment.
Please can you rebase and accept changes from main, this change should remain.
| @@ -721,3 +721,8 @@ variable "job_retry" { | |||
| error_message = "The maxium message delay for SWS is 900 seconds." | |||
| } | |||
| } | |||
|
|
|||
| variable "enable_runner_workflow_job_labels_check_all" { | |||
There was a problem hiding this comment.
Can you move this to the runner config, so it can be set per runner group.
No description provided.