backloged atm

philkra · Sep 5, 2019 · 7e70d49 · 7e70d49
1 parent ebaea91
commit 7e70d49
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/Events/DefaultEventFactory.php b/src/Events/DefaultEventFactory.php
@@ -31,7 +31,7 @@ public function newSpan(string $name, EventBean $parent): Span
     /**
      * {@inheritdoc}
      */
-    public function newMetricset($set, $tags): Metricset
+    public function newMetricset(array $set, array $tags = []): Metricset
     {
         return new Metricset($set, $tags);
     }

diff --git a/src/Events/EventFactoryInterface.php b/src/Events/EventFactoryInterface.php
@@ -45,6 +45,6 @@ public function newSpan(string $name, EventBean $parent): Span;
      *
      * @return Metricset
      */
-    public function newMetricset($set, $tags): Metricset;
+    public function newMetricset(array $set, array $tags = []): Metricset;
 
 }
diff --git a/src/Events/Metricset.php b/src/Events/Metricset.php
@@ -26,7 +26,7 @@ class Metricset extends EventBean implements \JsonSerializable
      * @param array $set
      * @param array $tags
      */
-    public function __construct(array $set, array $tags)
+    public function __construct(array $set, array $tags = [])
     {
         parent::__construct([]);
         foreach($set as $k => $v) {
@@ -47,6 +47,7 @@ public function jsonSerialize() : array
         return [
             'metricset' => [
                 'samples'   => $this->samples,
+//                'tags'      => $this->tags,
                 'timestamp' => $this->getTimestamp(),
             ]
         ];