Valid post/pre script format #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readme is updated with missing script format: a file with shebang chars and executable permissions
Subprocess exception handling is updated to print more information for the failed process call() reasons. This was particularly very useful when debugging why post/pre scripts are not executed properly.
phillipberndt
requested changes
Oct 10, 2021
| @@ -199,6 +199,17 @@ a new monitor, then you can use a `predetect` script to delay the execution. | |||
| Write e.g. `sleep 1` into that file to make autorandr wait a second before | |||
| running `xrandr`. | |||
|
|
|||
| ### Script format | |||
There was a problem hiding this comment.
Actually all that's needed is that the files are executable. They don't have to be shell scripts. (They don't even have to be scripts. A binary would work as well.)
| @@ -1050,7 +1050,8 @@ def exec_scripts(profile_path, script_name, meta_information=None): | |||
| if os.access(script, os.X_OK | os.F_OK): | |||
| try: | |||
| all_ok &= subprocess.call(script, env=env) != 0 | |||
| except: | |||
| except Exception as process_exception: | |||
| print(process_exception): | |||
There was a problem hiding this comment.
This looks like a syntax error.
Besides, what's the idea behind this print? Perhaps the same can be done more elegantly.
|
|
||
| Each script you are placing under valid configuration folders must follow **bash/sh/yourshell** format. As an example; | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
I like the idea of having a few examples. How about creating a folder under contrib and collecting all sorts of scripts there? We could then link to that folder from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr includes 2 commits;