Pull out media server and handling into separate container #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes Philomena to call image processing tools with an RPC broker client and server, to make upgrading them independently of Elixir easier and to allow them to have a separate memory space.
One can call the broker client with (e.g.)
broker broker:1500 execute-command -- file --mime-type -b image.png; this translation is directly integrated into the app, replacingSystem.cmd/2where it previously appeared for media processing.If you are not deploying using docker, broker should exist in PATH for the application, and you should compile broker_server and run it as a systemd service.