Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow new version of sebastian/version for phpunit 11 compatibility #1864

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

tkegan
Copy link
Contributor

@tkegan tkegan commented Sep 4, 2024

This PR recreates PR #1831 which I mistakenly closed thinking it to be obsolete. If accepted, this PR updates the allowed versions of the dependency sebastian/version allowing phing to be used in projects which wish to use phpunit version 11.x for testing.

Note because phing uses phpunit version 9 for unit testing which depends on sebastian/version version 3.x running unit tests alone is not a sufficient test of this dependency change. Instead a project needs to be created using phing and phpunit (at version 11) and the build.xml needs to include a target which invokes Phing::getPhingVersion. I've tried this in a closed source project but can come up with a stripped down example if desired.

@mrook mrook added this to the 3.0.1 milestone Sep 4, 2024
@andresiri
Copy link

andresiri commented Sep 5, 2024

Running into the same problem as well, any estimation for when this will be merged @mrook ?

In advance, i appreciate all the effort (:

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.57%. Comparing base (10e866f) to head (23a7712).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1864   +/-   ##
=========================================
  Coverage     53.57%   53.57%           
  Complexity     9809     9809           
=========================================
  Files           495      495           
  Lines         24198    24198           
=========================================
  Hits          12963    12963           
  Misses        11235    11235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siad007
Copy link
Member

siad007 commented Sep 13, 2024

@tkegan Thanks for your contribution. Would you mind to include the generated composer.lock file as well?

@pekral
Copy link

pekral commented Sep 23, 2024

Hi, is it possible to merge this pull request in the near future?

@tkegan
Copy link
Contributor Author

tkegan commented Sep 24, 2024

@tkegan Thanks for your contribution. Would you mind to include the generated composer.lock file as well?

Sorry I've been on call and I was kept hopping.

I'm not sure I understand. There are no changes to the composer.lock file required by this change. If I run composer update phpunit in the project for example, the checksum on line 7 of composer.lock is changed but that's it. If I instead use composer update various dependencies are updated but I have not vetted those changes.

It may be helpful to see phpunit 11 coexisting with phing in a project; so I threw together a stripped down sample project you can try here https://github.com/tkegan/phing-sample.

Hopefully this helps. If not or there is something more I can do please let me know.

@siad007 siad007 self-assigned this Sep 27, 2024
@siad007 siad007 merged commit b561201 into phingofficial:main Sep 27, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants