Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize manual with stubs for PHP 8.4 - part 4 #4186

Merged
merged 7 commits into from
Dec 2, 2024
Merged

Synchronize manual with stubs for PHP 8.4 - part 4 #4186

merged 7 commits into from
Dec 2, 2024

Conversation

kocsismate
Copy link
Member

No description provided.

cmb69
cmb69 reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me, besides the comment below.

reference/uodbc/functions/odbc-result.xml Show resolved Hide resolved
nielsdos
nielsdos reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me, but please fix cmb's comment and CI

Girgias
Girgias requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of text is being repeated (even if it was the case previously) where it would be better to use an XML entity or XIncludes.

The 2 things I notices are for the statement param, and the return an ODBC object or false on failure.

reference/uodbc/functions/odbc-execute.xml Outdated Show resolved Hide resolved
reference/uodbc/functions/odbc-fetch-array.xml Show resolved Hide resolved
reference/uodbc/functions/odbc-fetch-into.xml Outdated Show resolved Hide resolved
reference/uodbc/functions/odbc-fetch-array.xml Outdated Show resolved Hide resolved
reference/uodbc/functions/odbc-fetch-object.xml Outdated Show resolved Hide resolved
reference/uodbc/functions/odbc-field-len.xml Outdated Show resolved Hide resolved
reference/uodbc/functions/odbc-foreignkeys.xml Outdated Show resolved Hide resolved
reference/uodbc/functions/odbc-gettypeinfo.xml Outdated Show resolved Hide resolved
reference/uodbc/functions/odbc-num-rows.xml Outdated Show resolved Hide resolved
reference/uodbc/functions/odbc-setoption.xml Show resolved Hide resolved
Girgias
Girgias reviewed Dec 1, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, still some questions about the existing docs.

reference/uodbc/functions/odbc-binmode.xml Outdated Show resolved Hide resolved
reference/uodbc/setup.xml Outdated Show resolved Hide resolved
@KentarouTakeda KentarouTakeda mentioned this pull request Dec 2, 2024
Open
@Girgias Girgias mentioned this pull request Dec 2, 2024
Open
@kocsismate kocsismate merged commit ed1aff1 into php:master Dec 2, 2024
2 checks passed
@kocsismate kocsismate deleted the php84-sync-4 branch December 2, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos left review comments

@cmb69 cmb69 cmb69 left review comments

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
method synopsis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kocsismate @cmb69 @nielsdos @Girgias