-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update traits.xml Mention the hierarchy of classes, amend final
modifier example
#4188
Open
mmalferov
wants to merge
10
commits into
php:master
Choose a base branch
from
mmalferov:patch-493908
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a3d5f08
Update traits.xml Mention the hierarchy of classes
mmalferov 161c74b
Update language/oop5/traits.xml
mmalferov 1dbb0af
Update language/oop5/traits.xml
mmalferov 657a511
Update traits.xml Amend the 'final' modifier example
mmalferov 621e702
Update traits.xml Clarify how to using the `final` modifier
mmalferov aca1bc0
traits.xml Specify that this is a static property of a trait
mmalferov 73ea541
Update traits.xml Give a more clarity
mmalferov ccf917b
Update traits.xml fix a typo
mmalferov 5dc0e6c
Update language/oop5/traits.xml
mmalferov ef23f6f
Update language/oop5/traits.xml
mmalferov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a non-native speaker, I struggle a bit to understand the sentence. Maybe it could be cut in two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, a native English speaker (not me) will formulate it better, or changed it to single sentence at all, something like that:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to me, yes!