Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] socket update #4210

Merged
merged 2 commits into from
Dec 1, 2024
Merged

[PHP 8.4] socket update #4210

merged 2 commits into from
Dec 1, 2024

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Dec 1, 2024

for #3872

@devnexen devnexen added this to the PHP 8.4 milestone Dec 1, 2024
@devnexen devnexen requested a review from Girgias December 1, 2024 12:50
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits, but LGTM

reference/sockets/constants.xml Outdated Show resolved Hide resolved
reference/sockets/constants.xml Outdated Show resolved Hide resolved
reference/sockets/constants.xml Outdated Show resolved Hide resolved
reference/sockets/constants.xml Outdated Show resolved Hide resolved
reference/sockets/constants.xml Outdated Show resolved Hide resolved
reference/sockets/constants.xml Outdated Show resolved Hide resolved
reference/sockets/constants.xml Outdated Show resolved Hide resolved
reference/sockets/constants.xml Outdated Show resolved Hide resolved
reference/sockets/constants.xml Outdated Show resolved Hide resolved
reference/sockets/constants.xml Outdated Show resolved Hide resolved
@Girgias Girgias merged commit 8c41f7f into php:master Dec 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants