[PHP 8.3] ValueError's previous exception is now set in password_hash()

[alexandre-daubois]

Part of #2796

[jimwins]

I think both <classname> be <exceptionname>. Also:

Suggested change

	a <classname>ValueError</classname> is thrown if the salt generation fails.
	a <classname>ValueError</classname> is thrown because the salt generation fails.

[alexandre-daubois]

Updated!

[jimwins]

Ah, one other thing is I think you don't need the leading \ on the exception name or it won't get linked up properly. I haven't tested this, though.

[TimWolla]

Ah, one other thing is I think you don't need the leading \ on the exception name or it won't get linked up properly. I haven't tested this, though.

Indeed.

[kamil-tekiela]

Suggested change

	<function>password_hash</function> now sets the underlying
	<exceptionname>\Random\RandomException</exceptionname> as the previous exception when
	a <exceptionname>ValueError</exceptionname> is thrown because the salt generation fails.
	<function>password_hash</function> now sets the underlying
	<exceptionname>\Random\RandomException</exceptionname> as the previous exception when a
	<exceptionname>ValueError</exceptionname> is thrown due to a failure in salt generation.

[TimWolla]

The description correctly describes the change that happened. I'll defer the English phrasing to other reviewers.

[TimWolla]

Should previous perhaps be a <literal>$previous</previous>?

[Girgias]

I would prefer <property>Exception::$previous</property> then

[alexandre-daubois]

Updated with your suggestion