More specific function name and moved the test

Signed-off-by: Xheni Myrtaj <[email protected]>
phpList · Mar 19, 2019 · 2068fc2 · 2068fc2
1 parent ba0c892
commit 2068fc2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/Controller/ListController.php b/src/Controller/ListController.php
@@ -106,7 +106,7 @@ public function getMembersAction(Request $request, SubscriberList $list): View
      *
      * @return View
      */
-    public function getCountAction(Request $request, SubscriberList $list): View
+    public function getCountSubscribersAction(Request $request, SubscriberList $list): View
     {
         $this->requireAuthentication($request);
 

diff --git a/tests/Integration/Controller/ListControllerTest.php b/tests/Integration/Controller/ListControllerTest.php
@@ -335,7 +335,7 @@ public function getListMembersWithCurrentSessionKeyForExistingListWithSubscriber
     /**
      * @test
      */
-    public function getListCountForExistingListWithoutSessionKeyReturnsForbiddenStatus()
+    public function getListCountSubscribersForExistingListWithoutSessionKeyReturnsForbiddenStatus()
     {
         $this->getDataSet()->addTable(static::LISTS_TABLE_NAME, __DIR__ . '/Fixtures/SubscriberList.csv');
         $this->applyDatabaseChanges();
@@ -348,7 +348,7 @@ public function getListCountForExistingListWithoutSessionKeyReturnsForbiddenStat
     /**
      * @test
      */
-    public function getListCountForExistingListWithExpiredSessionKeyReturnsForbiddenStatus()
+    public function getListCountSubscribersForExistingListWithExpiredSessionKeyReturnsForbiddenStatus()
     {
         $this->getDataSet()->addTable(static::LISTS_TABLE_NAME, __DIR__ . '/Fixtures/SubscriberList.csv');
         $this->getDataSet()->addTable(static::ADMINISTRATOR_TABLE_NAME, __DIR__ . '/Fixtures/Administrator.csv');
@@ -369,7 +369,7 @@ public function getListCountForExistingListWithExpiredSessionKeyReturnsForbidden
     /**
      * @test
      */
-    public function getListCountWithCurrentSessionKeyForExistingListReturnsOkayStatus()
+    public function getListCountSubscribersWithCurrentSessionKeyForExistingListReturnsOkayStatus()
     {
         $this->getDataSet()->addTable(static::LISTS_TABLE_NAME, __DIR__ . '/Fixtures/SubscriberList.csv');
         $this->applyDatabaseChanges();
@@ -382,32 +382,32 @@ public function getListCountWithCurrentSessionKeyForExistingListReturnsOkayStatu
     /**
      * @test
      */
-    public function getListCountWithCurrentSessionKeyForExistingListWithSubscribersReturnsSubscribersCount()
+    public function getListCountSubscribersWithCurrentSessionKeyForExistingListWithNoSubscribersReturnsZero()
     {
         $this->getDataSet()->addTable(static::LISTS_TABLE_NAME, __DIR__ . '/Fixtures/SubscriberList.csv');
         $this->getDataSet()->addTable(static::SUBSCRIBER_TABLE_NAME, __DIR__ . '/Fixtures/Subscriber.csv');
         $this->getDataSet()->addTable(static::SUBSCRIPTION_TABLE_NAME, __DIR__ . '/Fixtures/Subscription.csv');
         $this->applyDatabaseChanges();
 
-        $this->authenticatedJsonRequest('get', '/api/v2/lists/2/count');
+        $this->authenticatedJsonRequest('get', '/api/v2/lists/3/count');
         $response = $this->getResponseContentAsInt();
-        
-        static::assertSame(1, $response);
+
+        static::assertSame(0, $response);
     }
 
     /**
      * @test
      */
-    public function getListCountWithCurrentSessionKeyForExistingListWithNoSubscribersReturnsZero()
+    public function getListCountSubscribersWithCurrentSessionKeyForExistingListWithSubscribersReturnsSubscribersCount()
     {
         $this->getDataSet()->addTable(static::LISTS_TABLE_NAME, __DIR__ . '/Fixtures/SubscriberList.csv');
         $this->getDataSet()->addTable(static::SUBSCRIBER_TABLE_NAME, __DIR__ . '/Fixtures/Subscriber.csv');
         $this->getDataSet()->addTable(static::SUBSCRIPTION_TABLE_NAME, __DIR__ . '/Fixtures/Subscription.csv');
         $this->applyDatabaseChanges();
 
-        $this->authenticatedJsonRequest('get', '/api/v2/lists/3/count');
+        $this->authenticatedJsonRequest('get', '/api/v2/lists/2/count');
         $response = $this->getResponseContentAsInt();
 
-        static::assertSame(0, $response);
+        static::assertSame(1, $response);
     }
 }