Replace array for string ...

This provides better typing
phparkitect · Aug 26, 2023 · fb43431 · fb43431
1 parent 976c200
commit fb43431
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Analyzer/ClassDescription.php b/src/Analyzer/ClassDescription.php
@@ -93,7 +93,7 @@ public function namespaceMatches(string $pattern): bool
         return $this->FQCN->matches($pattern);
     }
 
-    public function namespaceMatchesOneOfTheseNamespaces(array $classesToBeExcluded): bool
+    public function namespaceMatchesOneOfTheseNamespaces(string ...$classesToBeExcluded): bool
     {
         foreach ($classesToBeExcluded as $classToBeExcluded) {
             if ($this->namespaceMatches($classToBeExcluded)) {

diff --git a/src/Rules/ArchRule.php b/src/Rules/ArchRule.php
@@ -38,7 +38,7 @@ public function __construct(
 
     public function check(ClassDescription $classDescription, Violations $violations): void
     {
-        if ($classDescription->namespaceMatchesOneOfTheseNamespaces($this->classesToBeExcluded)) {
+        if ($classDescription->namespaceMatchesOneOfTheseNamespaces(...$this->classesToBeExcluded)) {
             return;
         }
 

diff --git a/tests/Unit/Analyzer/ClassDescriptionTest.php b/tests/Unit/Analyzer/ClassDescriptionTest.php
@@ -36,7 +36,7 @@ public function test_should_return_true_if_there_class_is_in_namespace_array():
     {
         $cd = $this->builder->build();
 
-        $this->assertTrue($cd->namespaceMatchesOneOfTheseNamespaces(['Fruit']));
+        $this->assertTrue($cd->namespaceMatchesOneOfTheseNamespaces('Fruit', 'Banana'));
     }
 
     public function test_should_return_true_if_is_annotated_with(): void