Skip to content

Commit

Permalink
Remove dir since it is not implemented
Browse files Browse the repository at this point in the history
fix test
  • Loading branch information
iMattPro committed Dec 21, 2024
1 parent 9b83d9e commit c6ea224
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
1 change: 0 additions & 1 deletion config/services.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,5 @@ services:
class: phpbb\webpushnotifications\controller\manifest
arguments:
- '@config'
- '@language'
- '@path_helper'
- '@user'
9 changes: 1 addition & 8 deletions controller/manifest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

use phpbb\config\config;
use phpbb\exception\http_exception;
use phpbb\language\language;
use phpbb\path_helper;
use phpbb\user;
use phpbb\webpushnotifications\ext;
Expand All @@ -24,9 +23,6 @@ class manifest
/** @var config */
protected $config;

/** @var language */
protected $language;

/** @var path_helper */
protected $path_helper;

Expand All @@ -38,14 +34,12 @@ class manifest
*
* @param config $config
* @param path_helper $path_helper
* @param language $language
* @param user $user
*/
public function __construct(config $config, language $language, path_helper $path_helper, user $user)
public function __construct(config $config, path_helper $path_helper, user $user)
{
$this->config = $config;
$this->path_helper = $path_helper;
$this->language = $language;
$this->user = $user;
}

Expand Down Expand Up @@ -73,7 +67,6 @@ public function handle(): JsonResponse
'short_name' => $pwa_short_name ?: utf8_substr($sitename, 0, 12),
'display' => 'standalone',
'orientation' => 'portrait',
'dir' => $this->language->lang('DIRECTION'),
'start_url' => $board_path,
'scope' => $board_path,
];
Expand Down
1 change: 0 additions & 1 deletion tests/functional/functional_test.php
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ public function test_manifest()
'short_name' => 'yourdomain',
'display' => 'standalone',
'orientation' => 'portrait',
'dir' => 'ltr',
'start_url' => '/',
'scope' => '/',
];
Expand Down

0 comments on commit c6ea224

Please sign in to comment.