Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide correct push worker update. #38

Merged
merged 6 commits into from
May 26, 2024

Conversation

rxu
Copy link
Contributor

@rxu rxu commented May 19, 2024

No description provided.

@rxu rxu marked this pull request as draft May 19, 2024 15:19
@rxu rxu force-pushed the update-push-worker branch from 2faa673 to fbf6ec2 Compare May 26, 2024 13:49
@rxu
Copy link
Contributor Author

rxu commented May 26, 2024

From ServiceWorkerRegistration: update() method docs:

The update() method of the ServiceWorkerRegistration interface attempts to update the service worker. It fetches the worker's script URL, and if the new worker is not byte-by-byte identical to the current worker, it installs the new worker. The fetch of the worker bypasses any browser caches if the previous fetch occurred over 24 hours ago.

@iMattPro iMattPro self-assigned this May 26, 2024
@iMattPro iMattPro added the bug Something isn't working label May 26, 2024
@rxu rxu marked this pull request as ready for review May 26, 2024 17:26
@rxu rxu requested a review from iMattPro May 26, 2024 17:26
@iMattPro iMattPro merged commit 4b0a2ed into phpbb-extensions:main May 26, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants