Subscribe Toggle in Notification Dropdown #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
|
@marc1706 look what we're cooking up |
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]> # Conflicts: # styles/prosilver/template/event/overall_footer_after.html
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
rxu
reviewed
May 31, 2024
| $sql_ary = []; | ||
|
|
||
| $sql = 'SELECT user_id | ||
| FROM ' . $this->table_prefix . 'users |
There was a problem hiding this comment.
Probably limit user types to USER_NORMAL and USER_FOUNDER to skip unused accounts.
| $sql = 'SELECT method | ||
| FROM ' . $this->table_prefix . "user_notifications | ||
| WHERE method = '" . $this->db->sql_escape('notification.method.phpbb.wpn.webpush') . "'"; | ||
| $result = $this->db->sql_query($sql); |
There was a problem hiding this comment.
I guess we need at least 1 positive result so probably $this->db->sql_query_limit($sql, 1).
| { | ||
| $sql = 'SELECT method | ||
| FROM ' . $this->table_prefix . "user_notifications | ||
| WHERE method = '" . $this->db->sql_escape('notification.method.phpbb.wpn.webpush') . "'"; |
There was a problem hiding this comment.
Maybe add AND notify = 1 as far as we're looking for enabled notification types.
There was a problem hiding this comment.
For this I'm just looking to see if it exists yet, because if it does it means it's already been installed and people have started making settings already.
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
rxu
approved these changes
May 31, 2024
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a new core template event in
notification_dropdown.htmlafter the footer DIV (likenotification_dropdown_footer_after)Depends on phpbb/phpbb#6625