Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General fixes #74

Merged
merged 11 commits into from
Aug 1, 2024
Merged

General fixes #74

merged 11 commits into from
Aug 1, 2024

Conversation

iMattPro
Copy link
Contributor

@iMattPro iMattPro commented Jul 14, 2024 •
edited
Loading

  • Fix not working links to web app icons
  • Improve loading notifications for valid users only
  • Fix manifest stuff not loading for guests

@iMattPro
Use absolute URLs for pwa icons
a69ab01 
Signed-off-by: Matt Friedman <[email protected]>
@iMattPro iMattPro requested a review from rxu July 15, 2024 15:16
@iMattPro iMattPro changed the title Manifest fixes General fixes Jul 17, 2024
iMattPro added 2 commits July 17, 2024 09:05
@iMattPro
Fix loading notifications for users in better way
c55aef6 
Signed-off-by: Matt Friedman <[email protected]>

fix

Signed-off-by: Matt Friedman <[email protected]>
@iMattPro
Improve disabled state JS
a156afb 
Signed-off-by: Matt Friedman <[email protected]>
iMattPro added 8 commits July 22, 2024 07:35
@iMattPro iMattPro merged commit 36a41c2 into phpbb-extensions:main Aug 1, 2024
32 checks passed
@iMattPro iMattPro deleted the manifest branch August 1, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxu rxu rxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iMattPro @rxu