Drop Utils\Routine class

Signed-off-by: Kamil Tekiela <[email protected]>
phpmyadmin · Sep 23, 2024 · d8cede5 · d8cede5
1 parent 1e1693e
commit d8cede5
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 552 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -875,51 +875,6 @@ parameters:
 			count: 1
 			path: src/Utils/Query.php
 
-		-
-			message: "#^Cannot access offset 'value' on mixed\\.$#"
-			count: 3
-			path: src/Utils/Routine.php
-
-		-
-			message: "#^Cannot access property \\$name on PhpMyAdmin\\\\SqlParser\\\\Components\\\\DataType\\|null\\.$#"
-			count: 2
-			path: src/Utils/Routine.php
-
-		-
-			message: "#^Cannot access property \\$options on PhpMyAdmin\\\\SqlParser\\\\Components\\\\DataType\\|null\\.$#"
-			count: 2
-			path: src/Utils/Routine.php
-
-		-
-			message: "#^Cannot access property \\$options on PhpMyAdmin\\\\SqlParser\\\\Components\\\\OptionsArray\\|null\\.$#"
-			count: 3
-			path: src/Utils/Routine.php
-
-		-
-			message: "#^Cannot access property \\$parameters on PhpMyAdmin\\\\SqlParser\\\\Components\\\\DataType\\|null\\.$#"
-			count: 3
-			path: src/Utils/Routine.php
-
-		-
-			message: "#^Cannot assign new offset to array\\<int\\<0, max\\>, mixed\\>\\|string\\.$#"
-			count: 1
-			path: src/Utils/Routine.php
-
-		-
-			message: "#^Method PhpMyAdmin\\\\SqlParser\\\\Utils\\\\Routine\\:\\:getParameter\\(\\) should return array\\<string\\> but returns array\\<int, string\\|null\\>\\.$#"
-			count: 1
-			path: src/Utils/Routine.php
-
-		-
-			message: "#^Method PhpMyAdmin\\\\SqlParser\\\\Utils\\\\Routine\\:\\:getReturnType\\(\\) should return array\\<string\\> but returns array\\<int, string\\|null\\>\\.$#"
-			count: 1
-			path: src/Utils/Routine.php
-
-		-
-			message: "#^Parameter \\#2 \\$array of function implode expects array\\|null, array\\<int\\<0, max\\>, mixed\\>\\|string given\\.$#"
-			count: 1
-			path: src/Utils/Routine.php
-
 		-
 			message: "#^Cannot access property \\$database on PhpMyAdmin\\\\SqlParser\\\\Components\\\\Expression\\|null\\.$#"
 			count: 1

diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -1161,68 +1161,6 @@
       <code><![CDATA[empty($statement->order)]]></code>
     </RiskyTruthyFalsyComparison>
   </file>
-  <file src="src/Utils/Routine.php">
-    <InvalidReturnStatement>
-      <code><![CDATA[[
-            $type->name,
-            implode(',', $type->parameters),
-            implode(' ', $options),
-        ]]]></code>
-      <code><![CDATA[[
-            empty($param->inOut) ? '' : $param->inOut,
-            $param->name,
-            $param->type->name,
-            implode(',', $param->type->parameters),
-            implode(' ', $options),
-        ]]]></code>
-    </InvalidReturnStatement>
-    <InvalidReturnType>
-      <code><![CDATA[string[]]]></code>
-      <code><![CDATA[string[]]]></code>
-    </InvalidReturnType>
-    <MixedArgumentTypeCoercion>
-      <code><![CDATA[$options]]></code>
-      <code><![CDATA[$options]]></code>
-      <code><![CDATA[$retval['opts'][$idx]]]></code>
-    </MixedArgumentTypeCoercion>
-    <MixedArrayAccess>
-      <code><![CDATA[$opt['value']]]></code>
-      <code><![CDATA[$opt['value']]]></code>
-      <code><![CDATA[$opt['value']]]></code>
-    </MixedArrayAccess>
-    <MixedAssignment>
-      <code><![CDATA[$opt]]></code>
-      <code><![CDATA[$opt]]></code>
-      <code><![CDATA[$opt]]></code>
-      <code><![CDATA[$options[]]]></code>
-      <code><![CDATA[$options[]]]></code>
-      <code><![CDATA[$retval['opts'][$idx][]]]></code>
-    </MixedAssignment>
-    <PossiblyNullArgument>
-      <code><![CDATA[$param->type->parameters]]></code>
-      <code><![CDATA[$param->type->parameters]]></code>
-    </PossiblyNullArgument>
-    <PossiblyNullIterator>
-      <code><![CDATA[$param->type->options->options]]></code>
-      <code><![CDATA[$param->type->options->options]]></code>
-      <code><![CDATA[$type->options->options]]></code>
-    </PossiblyNullIterator>
-    <PossiblyNullPropertyFetch>
-      <code><![CDATA[$param->type->name]]></code>
-      <code><![CDATA[$param->type->name]]></code>
-      <code><![CDATA[$param->type->options]]></code>
-      <code><![CDATA[$param->type->options]]></code>
-      <code><![CDATA[$param->type->options->options]]></code>
-      <code><![CDATA[$param->type->options->options]]></code>
-      <code><![CDATA[$param->type->parameters]]></code>
-      <code><![CDATA[$param->type->parameters]]></code>
-      <code><![CDATA[$type->options->options]]></code>
-    </PossiblyNullPropertyFetch>
-    <RiskyTruthyFalsyComparison>
-      <code><![CDATA[empty($param->inOut)]]></code>
-      <code><![CDATA[empty($statement->parameters)]]></code>
-    </RiskyTruthyFalsyComparison>
-  </file>
   <file src="src/Utils/Table.php">
     <LessSpecificReturnStatement>
       <code><![CDATA[$ret]]></code>
@@ -1500,13 +1438,6 @@
       <code><![CDATA[getTablesProvider]]></code>
     </PossiblyUnusedMethod>
   </file>
-  <file src="tests/Utils/RoutineTest.php">
-    <PossiblyUnusedMethod>
-      <code><![CDATA[getParameterProvider]]></code>
-      <code><![CDATA[getParametersProvider]]></code>
-      <code><![CDATA[getReturnTypeProvider]]></code>
-    </PossiblyUnusedMethod>
-  </file>
   <file src="tests/Utils/TableTest.php">
     <PossiblyUnusedMethod>
       <code><![CDATA[getFieldsProvider]]></code>

diff --git a/src/Utils/Routine.php b/src/Utils/Routine.php