Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ALTER regression #512

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

@MauricioFauth MauricioFauth added this to the 5.9.0 milestone Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (796b135) 97.02% compared to head (adfe314) 97.02%.
Report is 5 commits behind head on 5.8.x.

Additional details and impacted files
@@             Coverage Diff              @@
##              5.8.x     #512      +/-   ##
============================================
- Coverage     97.02%   97.02%   -0.01%     
- Complexity     2233     2236       +3     
============================================
  Files            69       69              
  Lines          5150     5144       -6     
============================================
- Hits           4997     4991       -6     
  Misses          153      153              
Files Changed Coverage Δ
src/Components/AlterOperation.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@williamdes
Copy link
Member

This should go to 5.8.x and then do a fast release for it
What do you think?

@MauricioFauth MauricioFauth changed the base branch from 5.9.x to 5.8.x September 19, 2023 12:18
- Fixes phpmyadmin#511
- Reverts phpmyadmin#485

Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@MauricioFauth MauricioFauth modified the milestones: 5.9.0, 5.8.2 Sep 19, 2023
@MauricioFauth MauricioFauth merged commit ab6f797 into phpmyadmin:5.8.x Sep 19, 2023
19 checks passed
@MauricioFauth MauricioFauth deleted the alter-regression branch September 19, 2023 12:32
@MauricioFauth MauricioFauth self-assigned this Sep 19, 2023
@williamdes williamdes removed their request for review April 22, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants