Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse SRID in column definition #595

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

MoonE
Copy link
Contributor

@MoonE MoonE commented Nov 1, 2024

Fixes phpmyadmin/phpmyadmin#18513

The parsing does not consider the db version and MariaDB does not support this.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@MauricioFauth MauricioFauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MauricioFauth MauricioFauth merged commit 2827a25 into phpmyadmin:5.10.x Nov 10, 2024
19 checks passed
@MauricioFauth MauricioFauth self-assigned this Nov 10, 2024
@MauricioFauth MauricioFauth added this to the 5.10.1 milestone Nov 10, 2024
@MoonE MoonE deleted the srid-in-column-definition branch November 10, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants