Add disable spy behavior #509
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
commented
Oct 27, 2020
| $objectProphecy->getMethodProphecies()->willReturn(array('method1' => array($method))); | ||
| $objectProphecy->getMethodProphecies('getName')->willReturn(array($method)); | ||
|
|
||
| $this->makeUnexpectedCallsFailFast(true); |
There was a problem hiding this comment.
This is the test that got deleted in #120, I tried to revert it back but this line doesn't seem to work; I need to call that method as a new precondition to make it pass, how should I do it?
|
How compatible is this with #518? |
|
@ciaranmcnulty I've already commented there: #518 (comment) We're battling the same issue in opposite directions: Prophecy's behavior is unclear when the subject of the prophecy has return types declared on its methods. We should discuss how to proceed, probably in #472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #508
This PR is incomplete, I don't know how to fix the new specs.